Translate server #16
Open
Translate server #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
although the code is messy :(
Apparently kernel.src cannot be directly assigned in v3, so store src in a local copy and modify that one before applying the updates. Tested on simulated streaming audio locally. see openai/whisper#2597
The previous commit added Triton 3.x support but broke backward compatibility with Triton 2.x by requiring triton>=3.0.0. This commit restores compatibility with both versions by following the upstream OpenAI Whisper approach: - Use hasattr() to detect which API is available - Call _unsafe_update_src() + hash reset for Triton 3.0-3.1 - Fall back to kernel.src for Triton 2.x - Restore triton>=2.0.0 requirement (supports both 2.x and 3.x) This matches the implementation in openai/whisper and addresses the maintainer feedback to follow upstream more closely. Builds on: #22 See: openai/whisper#2597
so that the code is identical
- bugfixes, catch-up, hovercraft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate server works.
But documentation is not good and žžžendofranslatežžž as well. Json would be better.
📄 Contributor License Agreement Consent
The authors of SimulStreaming wish to enhance ways to collect and use feedback from users of SimulStreaming in future research and development while not limiting community contributions and non-commercial use. Therefore, this project is dual-licenced; the commercial use requires registration before obtaining a commercial licence.
Before we merge this pull request, we kindly ask you to consider granting the permissions below. If you have questions or prefer a different arrangement, feel free to leave a comment or contact the author. Thank you!
By checking the boxes below, you confirm the following:
I confirm that I have the legal right to grant a license for the contributions in this pull request to the maintainers of the SimulStreaming project.
(For example, you are the only author, of legal age, not restricted by employment or institutional agreements.)
I grant the maintainers of SimulStreaming permission to re-license my contribution under any license, including commercial ones.