Conversation
…encoded should interpolate {{variables}}
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe change adds explicit interpolation for string form-urlencoded bodies in the CLI path and adds equivalent explicit handling in the Electron path. Tests cover environment variables, request-level global variables, and array-based form fields. ChangesForm-urlencoded interpolation
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Form-urlencoded text bodies retain variable interpolation across the CLI and Electron paths, with no actionable merge risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Form fields wake in a string of light Comment |
BRU-4556
TEXT body with Content-Type: application/x-www-form-urlencoded should interpolate variables
Problem
When a request uses Body type TEXT and the header Content-Type: application/x-www-form-urlencoded, variables in the body stay as literal {{var}} at send time.
The editor highlights them as resolved, and the URL interpolates correctly. Timeline shows the body was sent unresolved.
This is a possible regression of #2400 (closed as fixed in v1.35).
Root cause: urlencoded interpolation only runs when request.data is an array (Form URL Encoded fields). TEXT body is a string, so that branch does nothing. URL uses a different path, so it still interpolates.
Fix
Add interpolation if request.data is string
Screenshots
Before:

After:

Contribution Checklist:
Summary by CodeRabbit
Bug Fixes
application/x-www-form-urlencodedrequest bodies.Tests