feat: channel group #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add query schema validation to GET /channel-groups endpoint - Add comment explaining Set reassignment for Svelte 5 reactivity - Document all review responses in REVIEW.md
Deploying prism with
|
| Latest commit: |
674c02d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fb745b84.prism-c7z.pages.dev |
| Branch Preview URL: | https://feat-channel-group.prism-c7z.pages.dev |
- Add validation in PATCH /channel-groups to prevent circular parent references by traversing ancestors - Extract ChannelItem.svelte for reusable channel link display - Extract DMSection.svelte for DM section with state management - Reduce ChannelList.svelte from 205 to 155 lines - Reduce ChannelGroup.svelte from 112 to 88 lines
- Add right-click context menu for channel groups with options: - New Channel / New Group (create children) - Rename / Delete group - Add right-click context menu for channels with options: - Edit Channel (name/description) - Move to group (submenu) - Remove from group - Add visual separator between grouped and ungrouped channels - Add PATCH /channels/:id endpoint for channel editing
- Add DELETE /channels/:id endpoint with permission check - Add delete option to channel context menu with confirmation dialog - Change channel ordering from createdAt to alphabetical by name
- Extract ChannelList business logic to ChannelList.controller.svelte.ts - Replace native confirm() with DaisyUI modal (ConfirmModal) - Add toast notifications for success/error feedback - Simplify modal state management (remove registerOpen pattern) - Use ChannelGroup type from @packages/api-client directly - Add DB migration for channel_groups table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.