Skip to content

fix(uucore): Use embedded locales in release mode. #9879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lordeji wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(uucore): Use embedded locales in release mode. #9879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bd08d4
fix(uucore): Use embedded locales in release mode.
lordeji Dec 27, 2025
2e2305e
workflows/l10n.yml: Fix l10n_installation_test.
lordeji Dec 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions .github/workflows/l10n.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,6 +595,10 @@ jobs:
## Test installation via make with DESTDIR
echo "Testing make install with l10n features..."

# Set French locale
export LANG=fr_FR.UTF-8
export LC_ALL=fr_FR.UTF-8

# Create installation directory
MAKE_INSTALL_DIR="$PWD/make-install-dir"
mkdir -p "$MAKE_INSTALL_DIR"
Expand Down Expand Up @@ -632,10 +636,6 @@ jobs:
if [ "${{ matrix.job.os }}" = "ubuntu-latest" ]; then
echo "Testing French localization with make-installed binary..."

# Set French locale
export LANG=fr_FR.UTF-8
export LC_ALL=fr_FR.UTF-8

echo "Testing ls --help with French locale..."
ls_help=$("$MAKE_INSTALL_DIR/usr/bin/coreutils" ls --help 2>&1 || echo "Command failed")
echo "ls help output (first 10 lines):"
Expand Down Expand Up @@ -697,6 +697,10 @@ jobs:
## Test installation via cargo install with DESTDIR-like approach
echo "Testing cargo install with l10n features..."

# Set French locale
export LANG=fr_FR.UTF-8
export LC_ALL=fr_FR.UTF-8

# Create installation directory
CARGO_INSTALL_DIR="$PWD/cargo-install-dir"
mkdir -p "$CARGO_INSTALL_DIR"
Expand Down
Loading
Loading