stty: use stdin for TTY operations instead of /dev/tty #9881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed comments of how this came up in #8608
It turns out that the cause of a bunch of bugs that we have been seeing with stty compared to GNU have been caused by us defaulting to /dev/tty and stdout instead of stdin. This shows up in the stty -g output being different, differences in error messaging and differences related to how stty is able to parse piped input.
I added a bunch of integration test cases from the original errors: #8016 to make sure that we aren't regressing with this change and to address the reason this code was added in the first place.