-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
date: fix handling of case-change flags in locale format specifiers #9897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CrazyRoka
wants to merge
3
commits into
uutils:main
Choose a base branch
from
CrazyRoka:date-implement-locale-specific
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
230c85d to
3654036
Compare
|
GNU testsuite comparison: |
Contributor
|
lot of jobs are failing |
3654036 to
bf1c296
Compare
bf1c296 to
f494fa5
Compare
|
GNU testsuite comparison: |
sylvestre
reviewed
Dec 30, 2025
sylvestre
reviewed
Dec 30, 2025
sylvestre
reviewed
Dec 30, 2025
- Add documentation for distribute_flag helper. - Add unit tests for flag distribution and locale expansion. - Add integration test for locale expansion with uppercase flag.
65b15f3 to
49f0f26
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, applying flags like
'^'(uppercase) or'#'(swap case) to locale-dependent specifiers (like%c,%x,%X) failed to affect the output. This occurred because the implementation passed these specifiers directly to the underlying formatter, which treats%cas a single unit without inheriting flags for its expanded components.For example,
LC_ALL=C TZ=UTC cargo run --bin coreutils date -d 2024-01-01 +%^cproduced "2024 M01 1, Mon 00:00:00", whereas GNUdateproduces "MON JAN 1 00:00:00 2024".This change pre-processes the format string to expand
%c,%x, and%Xusingnl_langinfo.This aligns behavior with GNU coreutils and we are now passing
subfmt-up1edge case intests/date/date.pl