Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/env.cc
Original file line number Diff line number Diff line change
Expand Up @@ -610,7 +610,7 @@ IsolateData::~IsolateData() {}
// Deprecated API, embedders should use v8::Object::Wrap() directly instead.
void SetCppgcReference(Isolate* isolate,
Local<Object> object,
void* wrappable) {
v8::Object::Wrappable* wrappable) {
v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
isolate, object, wrappable);
}
Expand Down
7 changes: 4 additions & 3 deletions src/node.h
Original file line number Diff line number Diff line change
Expand Up @@ -1540,9 +1540,10 @@ void RegisterSignalHandler(int signal,
// work with only Node.js versions with v8::Object::Wrap() should use that
// instead.
NODE_DEPRECATED("Use v8::Object::Wrap()",
NODE_EXTERN void SetCppgcReference(v8::Isolate* isolate,
v8::Local<v8::Object> object,
void* wrappable));
NODE_EXTERN void SetCppgcReference(
v8::Isolate* isolate,
v8::Local<v8::Object> object,
v8::Object::Wrappable* wrappable));

} // namespace node

Expand Down
2 changes: 1 addition & 1 deletion test/addons/cppgc-object/binding.cc
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#include <v8.h>
#include <algorithm>

class CppGCed : public cppgc::GarbageCollected<CppGCed> {
class CppGCed : public v8::Object::Wrappable {
public:
static uint16_t states[2];
static constexpr int kDestructCount = 0;
Expand Down
2 changes: 1 addition & 1 deletion test/cctest/test_cppgc.cc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
// This tests that Node.js can work with an existing CppHeap.

// Mimic a class that does not know about Node.js.
class CppGCed : public cppgc::GarbageCollected<CppGCed> {
class CppGCed : public v8::Object::Wrappable {
public:
static int kConstructCount;
static int kDestructCount;
Expand Down
Loading