Conversation
Picks up the redirect-interceptor fix (vadimpiven/node-addon-slsa#46, activated by #47): the verify-addons action was silently dropping GitHub release 302→CDN redirects when passed `getGlobalDispatcher()`, hashing zero bytes, and failing Rekor lookup with `e3b0c44…b855` (SHA-256 of empty). - `.github/workflows/release.yaml`: publish.yaml pin v0.8.10 → v0.8.12 - `packages/node/package.json`: node-addon-slsa 0.8.2 → 0.8.12 - `pnpm-lock.yaml`: regenerated Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Greptile SummaryThis PR bumps Confidence Score: 5/5Safe to merge — purely a dependency version bump with no logic changes and full internal consistency. All changed files are consistent with each other (package.json, lock file, and workflow pin all target v0.8.12). No new logic was introduced; the change only updates a pinned dependency to pick up an upstream bug fix. No P0 or P1 findings. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "Bump node-addon-slsa to v0.8.12" | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request updates the node-addon-slsa dependency from version 0.8.2 to 0.8.12. A potential compatibility issue was identified where the new dependency version requires Node.js >=22.12.0, which conflicts with the package's existing engine specification for Node.js ^20.19.0. This discrepancy could lead to installation failures or warnings for users on older Node.js versions.
| }, | ||
| "dependencies": { | ||
| "node-addon-slsa": "0.8.2" | ||
| "node-addon-slsa": "0.8.12" |
There was a problem hiding this comment.
The update to node-addon-slsa@0.8.12 maintains a dependency that requires Node.js >=22.12.0 (as seen in the lockfile), which conflicts with this package's stated support for Node.js ^20.19.0 in the engines field. This discrepancy may cause installation failures or warnings for users on Node 20. Consider updating the engines field to align with the requirements of your dependencies. Additionally, the pull request description mentions a change to .github/workflows/release.yaml which is not present in the current diff. Please verify if that file was intended to be included.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Picks up the redirect-interceptor fix
(vadimpiven/node-addon-slsa#46, activated by #47): the verify-addons action was silently dropping GitHub release 302→CDN redirects when passed
getGlobalDispatcher(), hashing zero bytes, and failing Rekor lookup withe3b0c44…b855(SHA-256 of empty)..github/workflows/release.yaml: publish.yaml pin v0.8.10 → v0.8.12packages/node/package.json: node-addon-slsa 0.8.2 → 0.8.12pnpm-lock.yaml: regenerated