Skip to content

Net9 and keep alive strategies#33

Merged
vadrsa merged 6 commits intovadrsa:masterfrom
Blazpelko:net9-and-keep-alive-strategies
May 12, 2025
Merged

Net9 and keep alive strategies#33
vadrsa merged 6 commits intovadrsa:masterfrom
Blazpelko:net9-and-keep-alive-strategies

Conversation

@Blazpelko
Copy link
Copy Markdown
Contributor

@Blazpelko Blazpelko commented Apr 25, 2025

Hello,

this is PR for issue.

Summary

  • Upgraded the solution to use .NET 9.
  • Added an option to configure WebSocket middleware settings through WebSocketConnectionDispatcherOptions.

Notes

  • Visual Studio reformatted several files automatically. What formatter or settings should we standardize on to avoid unnecessary diffs and merge conflicts in the future?
  • Projects under the /Example folder are still targeting .NET 8. These can be updated once the new NuGet packages are published.
  • Visual studio keept generating launchSettings.json for PingPong.Server so I kept it in the project
  • All tests have passes

I will be happy to hear your thoughts and suggestions.

Comment thread ext/SimpleR.Ocpp/SimpleR.Ocpp.csproj Outdated
Copy link
Copy Markdown
Owner

@vadrsa vadrsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review, a small comment, otherwise lgtm

Comment thread src/SimpleR/WebSocketOptions.cs
@vadrsa
Copy link
Copy Markdown
Owner

vadrsa commented May 12, 2025

Thanks @Blazpelko

@vadrsa vadrsa merged commit 33fd307 into vadrsa:master May 12, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants