Repository navigation
fix(release): keep trailing newline when updating package.json version - #52
Merged
Merged
Conversation
updateVersion wrote JSON.stringify output without a trailing newline, so every release commit stripped it from package.json and failed `vp check` on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
a145789
force-pushed
the
fix/package-json-trailing-newline
branch
from
October 16, 2026 03:56
a8d657c to
46222a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Lint workflow fails on the
v2.3.0release commit (run):vp checkreports a formatting issue inpackage.json.updateVersionwritesJSON.stringify(config, null, 2)back without a trailing newline, so every release commit strips the final newline from eachpackage.json. This also affects every project that releases withvr releaseorrt release.updateVersionnow appends\n.package.json.updateVersiontest now asserts that the file ends with a newline.Test plan
vp check: formatting, lint and type checks passvp test run: 135 passed🤖 Generated with Claude Code