fix: update app description to reflect accurate location#187
fix: update app description to reflect accurate location#187vbuch merged 25 commits intovbuch:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the Valery Buchinsky's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
It should actually be based on the LOCALITY of the instance. There needs to be a registry to map to that correctly |
|
Summary of Committed Changes: Core Locality Features: |
There was a problem hiding this comment.
Pull request overview
This PR updates the app description to be dynamically generated based on the configured locality, moving from a hardcoded description specific to "район Оборище" (Oborishte district) to a more flexible system that supports multiple localities. The change enables the application to serve different localities with appropriate metadata and descriptions.
Changes:
- Replaced static manifest.json with a dynamic Next.js route handler that generates the manifest based on the NEXT_PUBLIC_LOCALITY environment variable
- Added locality metadata registry with display names, English names, country codes, and descriptions
- Updated page metadata in layout.tsx to use locality-specific descriptions from the shared package
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| web/public/manifest.json | Deleted static manifest file |
| web/app/manifest.webmanifest/route.ts | Added dynamic manifest generation route with locality-specific metadata |
| web/app/layout.tsx | Updated to use getLocalityDescription() helper and changed manifest reference |
| shared/src/bounds.ts | Added LocalityMetadata interface and helper functions for accessing locality metadata |
| shared/src/bounds.test.ts | Added comprehensive test coverage for new metadata functions |
| shared/tsconfig.json | Removed test file exclusion from build configuration |
| shared/package.json | Added ESLint dependencies and lint script |
| shared/eslint.config.mjs | Added ESLint configuration for the shared package |
| docs/features/multi-locality-support.md | Updated documentation with locality metadata registry information |
| pnpm-lock.yaml | Updated lockfile with new dependencies |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ty-specific metadata
…undefined metadata
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
vbuch
left a comment
There was a problem hiding this comment.
I'm absolutely happy with it. I've only added a bit of a nitpicky comment. Let's see what Copilot thinks.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…tyRegistriesInSync function
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.