Fix Supply Chain CI: ignore unreachable quick-xml DoS advisories - #39
Merged
Conversation
The Supply Chain CI job started failing on RUSTSEC-2026-0194 and
RUSTSEC-2026-0195, two DoS advisories against quick-xml < 0.41.0
(quadratic start-tag attribute check and unbounded NsReader namespace
allocation).
Both only affect parsing of untrusted XML. In this tree quick-xml is
pulled in on two build-time, trusted-input paths only:
- wayland-scanner (^0.39, pinned via winit 0.30.x) generates code from
the crate-bundled Wayland protocol XML at build time.
- xcb (a dev-only build-dependency via xcap) parses the X11 protocol
XML at build time.
Neither parses untrusted runtime input, so the advisories are not
reachable. Upgrading quick-xml to >= 0.41.0 is not possible without
replacing the entire winit-pinned wayland stack, so the advisories are
ignored with justification, consistent with the existing entries.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014JQhuuZGmCaHNzMRwHnBQG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the Supply Chain job is failing
The
Supply Chainjob runscargo deny check advisories, which started failing on newly published advisories againstquick-xml < 0.41.0:NsReader(memory-exhaustion DoS). This one landed in the advisory DB after the last CI run, so it only surfaced once 0194 was addressed.Both fire on two transitive copies of quick-xml in the tree:
0.39.4and0.30.0.Why an upgrade isn't possible
quick-xml >= 0.41.0fixes both, but it can't be pulled in:wayland-scanner 0.31.10pinsquick-xml = "^0.39", and the whole wayland stack is pinned bywinit 0.30.13. Bumping quick-xml would require replacing the entire winit-pinned wayland stack.Why it's safe to ignore
Both advisories only affect parsing of untrusted XML. In this crate, quick-xml is only reached on build-time paths over trusted, crate-bundled input:
wayland-scanner(proc-macro) generates code from the bundled Wayland protocol XML at build time.xcb— a dev-only build-dependency viaxcap— parses the X11 protocol XML at build time.No untrusted runtime XML is ever handed to quick-xml, so neither DoS is reachable.
Change
Add both advisory IDs to the
ignorelist indeny.tomlwith a justification comment, consistent with the existing entries. Verified locally thatcargo deny --all-features check advisories,licenses,bans, andsourcesall pass.🤖 Generated with Claude Code
Generated by Claude Code