Refactoring switch to array options#121
Closed
gabrielferreiraa wants to merge 1 commit intovercel:masterfrom
Closed
Refactoring switch to array options#121gabrielferreiraa wants to merge 1 commit intovercel:masterfrom
gabrielferreiraa wants to merge 1 commit intovercel:masterfrom
Conversation
|
While this certainly feels more consolidated, it has strong negative effect on performance. I tried to do the same thing in #120 initially. Is a bummer! |
Contributor
|
Given that it has a negative impact on performance, we are going to close this PR. Thank you regardless 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed unnecessary repetitions in the switch in
parsemethod