[Fix] GoAccess ignore historical compressed files#1142
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR updates GoAccess log analysis to exclude compressed logs. The service version constant is incremented from 1 to 2, and the log processing script now filters files to skip ChangesLog Processing Update
Estimated Code Review Effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the GoAccess log-analysis ingestion script to avoid passing already-rotated compressed log files (*.gz) directly into GoAccess during the normal incremental run path. This prevents GoAccess from aborting when it encounters compressed rotations, improving reliability for long-running log ingestion across month boundaries.
Changes:
- Filter
LOG_GLOBinputs to only include existing, uncompressed log files (*.gzexcluded) for the normal (non-boundary) incremental GoAccess run. - Keep the boundary-window behavior intact (still uses
zcat -fto reread across months when needed). - Bump the GoAccess script version to force updated script deployment.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| resources/views/ssh/services/log_analysis/goaccess/bin/process.blade.php | Builds an explicit input file list and excludes *.gz files before invoking GoAccess in the normal incremental path. |
| app/Services/LogAnalysis/GoAccess/GoAccess.php | Increments SCRIPT_VERSION to propagate the updated processing script to servers. |
This pull request makes a minor update to the
GoAccesslog analysis service, ignoring compressed log files, as these will have already been read, but during boundary crossing are read via zcat -f. Fixes a critical failure on log file ingestion over multiple months.To apply the fix to an existing server, navigate to Server -> Services -> GoAccess -> ... -> Re-sync stats scripts
Summary by CodeRabbit