Process all outstanding honor maintenance periods in a single run.#3248
Draft
mserajnik wants to merge 2 commits intovmangos:developmentfrom
Draft
Process all outstanding honor maintenance periods in a single run.#3248mserajnik wants to merge 2 commits intovmangos:developmentfrom
mserajnik wants to merge 2 commits intovmangos:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
This makes it so that all outstanding honor maintenance periods (weeks) are processed in a single run, without requiring multiple restarts. This is mainly useful for private instances where there might be long periods where VMaNGOS isn't running (e.g., because the users take a multi-month break from playing).
Several queries have been changed to use
DirectExecute/DirectPExecuteto prevent async DB race conditions (ensure data is written before the next iteration).Needs testing, thus marked as Draft for now.
Proof
Issues
How2Test
Todo / Checklist