nghttp3: include static libs in build #58938
Closed
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NyaaaWhatsUpDoc
force-pushed
the
nghttp3-add-static-libs
branch
from
9c3931b to
dfa8df0
Compare
NyaaaWhatsUpDoc
force-pushed
the
nghttp3-add-static-libs
branch
from
dfa8df0 to
8f70538
Compare
Member
|
Too much trouble, no return! |
Contributor
Author
this is a relatively small library that takes no time at all to (re)build, and the return is that we now have a static nghttp3 library available for those looking for it in the devel package. we have static libraries available in most other devel packages, why not here too? i myself would have found it useful, hence why i made a PR. if you're set on an answer that's fine, i just don't quite understand the logic and seeking further explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing the changes
Updates the nghttp3 template to build and include static library files in devel package.
cc: @sgn