Repository navigation
Allow create-vite-plus preview builds - #132
Merged
Merged
Conversation
liangmiQwQ
marked this pull request as ready for review
October 14, 2026 10:36
fengmk2
approved these changes
Oct 14, 2026
fengmk2
pushed a commit
to voidzero-dev/vite-plus
that referenced
this pull request
Oct 14, 2026
This PR prepares the registry bridge preview publish for `create-vite-plus`, added in #3028. `publish-preview-register.yml` runs from `main` through `workflow_run`, so #3028 can't change it for its own preview build. Without this, the upload step rejects the `create-vite-plus` tarball because the action's default `workspace-packages` only allows `vite-plus,@voidzero-dev/vite-plus-*`, and the whole preview publish fails. This PR: - passes `workspace-packages` with `create-vite-plus` to the upload step. It is an allowlist, so PRs that don't pack the package are unaffected. - adds `create-vite-plus` to the preview comment, with instructions to create a project from the build. They set both `npm_config_registry` and `pnpm_config_registry` (pnpm 11+ only reads the latter), and keep it exported because the new project pins the preview version. It depends on voidzero-dev/pkg-pr-registry-bridge#132, which allows `create-vite-plus` on the bridge. Until #3028 merges, preview comments on other PRs will also list `create-vite-plus`, although only #3028 builds it. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
create-vite-plustoWORKSPACE_PACKAGES, so the bridge accepts and serves its preview builds.Vite+ adds the
create-vite-pluspackage in voidzero-dev/vite-plus#3028, and voidzero-dev/vite-plus#3048 lets its preview workflows publish it. Without this, the upload of its tarball is rejected, and reads ofcreate-vite-plusare redirected to npm, sopnpm create vite-plus@0.0.0-commit.<sha>can't resolve.config/production.envneeds to be synced to production and staging withvoid secret syncafter merging.🤖 Generated with Claude Code