Skip to content

fix(env): invalidate stale shim cache when project source changes#1951

Merged
fengmk2 merged 5 commits into
voidzero-dev:mainfrom
jong-kyung:fix-1948-shim-cache-devengines
Jun 26, 2026
Merged

fix(env): invalidate stale shim cache when project source changes#1951
fengmk2 merged 5 commits into
voidzero-dev:mainfrom
jong-kyung:fix-1948-shim-cache-devengines

Conversation

@jong-kyung

@jong-kyung jong-kyung commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Revalidates shim resolve cache entries against the current effective project Node.js version source.
  • Shares project version source resolution between env config resolution and shim cache validation to keep fallback behavior consistent.
  • Adds coverage for stale fallback cache invalidation and invalid-source fallback cases.

Fixes #1948

@netlify

netlify Bot commented Jun 26, 2026

Copy link
Copy Markdown

Deploy Preview for viteplus-preview canceled.

Name Link
🔨 Latest commit 84ce76c
🔍 Latest deploy log https://app.netlify.com/projects/viteplus-preview/deploys/6a3de4c22d2f11000892559a

@jong-kyung jong-kyung self-assigned this Jun 26, 2026
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f7df41f2a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_global_cli/src/shim/dispatch.rs Outdated
@jong-kyung jong-kyung force-pushed the fix-1948-shim-cache-devengines branch from f7df41f to ff13a96 Compare June 26, 2026 01:30
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff13a96e0b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread crates/vite_global_cli/src/shim/dispatch.rs Outdated
@jong-kyung

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: bc4560a2ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jong-kyung jong-kyung marked this pull request as ready for review June 26, 2026 02:19
@jong-kyung jong-kyung requested a review from fengmk2 June 26, 2026 02:19
@jong-kyung jong-kyung force-pushed the fix-1948-shim-cache-devengines branch from bc4560a to 84ce76c Compare June 26, 2026 02:32
@fengmk2 fengmk2 merged commit aba7091 into voidzero-dev:main Jun 26, 2026
40 checks passed
@jong-kyung jong-kyung deleted the fix-1948-shim-cache-devengines branch June 26, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

devEngines.runtime is not respected by node shim consistently

2 participants