feat(cli): advertise VP_USER_AGENT to child processes#1958
Draft
fengmk2 wants to merge 3 commits into
Draft
Conversation
Set `VP_USER_AGENT=vp/<version>` once at startup so spawned tools can detect vp as the package manager. Underlying package managers overwrite `npm_config_user_agent`, so a dedicated variable is needed. Enables `vp dlx create-vite` to scaffold with vp commands.
✅ Deploy Preview for viteplus-preview canceled.
|
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2d9a056834
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When vp runs as a managed npm/npx/node shim, the user is invoking that tool, not vp, so clear VP_USER_AGENT before dispatching the shim. Otherwise a child like create-vite would wrongly scaffold vp commands.
Detect shim mode in `main` before the runtime starts and set VP_USER_AGENT only when not a shim, instead of setting it unconditionally and clearing it in the shim branch. Also makes `detect_shim_tool` run genuinely single-threaded (it clears VP_SHIM_TOOL), matching its own SAFETY note.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
vpruns a tool (e.g.vp dlx create-vite), the child can't tell it was launched by vp. The underlying package manager (pnpm/npm/yarn/bun) overwritesnpm_config_user_agentwith its own value, so that channel can't carry the vp signal.Fix
Set a dedicated
VP_USER_AGENT=vp/<version>env var once at startup, inherited by every child process. Tools like create-vite can read it to detect vp and scaffold withvp install/vp dev/vp dlx.VP_USER_AGENTconstant to the centralenv_varsregistry.main, before the async runtime starts (edition 2024set_varmust run single-threaded), mirroring thevite_installerpattern. This covers all dlx paths including thenpxfallback used when there is no localpackage.json.Companion
create-vite reads
VP_USER_AGENT: vitejs/vite#22788