Skip to content

Support PEP 649/749 on Python 3.14+ - #107

Merged
volfpeter merged 2 commits into
mainfrom
feat/pep-649-support
Sep 8, 2026
Merged

volfpeter merged 2 commits into
mainfrom
feat/pep-649-support

Conversation

@volfpeter

@volfpeter volfpeter commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes

    • Improved function signature handling for quoted annotations.
    • Added compatibility for lazily evaluated annotations in Python 3.14 and later.
  • Tests

    • Added coverage for quoted annotations and Python 3.14+ forward-reference behavior.
  • Chores

    • Updated the package version to 3.2.3.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 9db363fe-70c5-4bef-bb94-660a44dfa917

📥 Commits

Reviewing files that changed from the base of the PR and between 400d700 and 7ab9cdf.

📒 Files selected for processing (1)
  • fasthx/__init__.py

Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review.


Walkthrough

The change adds version-aware signature retrieval in fasthx.utils, updates append_to_signature to use it, adds annotation tests, and increments the package version to 3.2.3.

Changes

Signature annotation handling

Layer / File(s) Summary
Version-aware signature retrieval
fasthx/utils.py
_get_signature evaluates annotations when possible and preserves forward references for unresolved names on Python 3.14 and later. append_to_signature uses this helper.
Annotation behavior tests
tests/test_utils.py
Tests verify quoted annotations and Python 3.14 lazy annotations from type-checking-only names.
Package version update
fasthx/__init__.py
The package version changes from 3.2.2 to 3.2.3.

Priority: ⬇️ Low — Defer the Python 3.14 annotation compatibility change because it is a narrow utility update with focused tests and no stated customer or external urgency.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 7ab9c

This change adds Python 3.14-aware signature handling for unresolved annotations and releases it as version 3.2.3. The covered annotation behaviors and package version source present no current merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding support for PEP 649/749 on Python 3.14 and newer.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/pep-649-support

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@volfpeter
volfpeter merged commit a0c744c into main Sep 8, 2026
6 checks passed
@volfpeter
volfpeter deleted the feat/pep-649-support branch September 8, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant