Fix: incorrect child vector size in duckdb list array import #5740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
connortsui20
force-pushed
the
ct/fix-duckdb-list-import
branch
from
38989db to
6fe3109
Compare
Contributor
Author
|
decided to add specialization on the validity |
connortsui20
force-pushed
the
ct/fix-duckdb-list-import
branch
2 times, most recently
from
36af150 to
896dc20
Compare
Signed-off-by: Connor Tsui <[email protected]>
connortsui20
force-pushed
the
ct/fix-duckdb-list-import
branch
from
896dc20 to
85a75c3
Compare
Contributor
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb NVMeSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Contributor
Benchmarks: FineWeb S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Contributor
Benchmarks: TPC-H SF=10 on S3Summary
Detailed Results Table
|
Contributor
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
robert3005
reviewed
Jan 3, 2026
vortex-duckdb/src/convert/vector.rs
Outdated
|
|
||
| let (offsets, sizes, child_max_length) = process_duckdb_lists(entries, &validity); | ||
| let child_data = | ||
| flat_vector_to_vortex(&mut vector.list_vector_get_child(), child_max_length)?; |
Contributor
There was a problem hiding this comment.
doesn't this have to be the sum of the lengths not the max? You're exporting this many elements of children
Contributor
Author
There was a problem hiding this comment.
Hmm I guess the name is a bit confusing? This is the maximum over all ends of the list views into the child vector
Contributor
Author
There was a problem hiding this comment.
Actually the correct name here is child_min_length which is the max over all view ends
Signed-off-by: Connor Tsui <[email protected]>
robert3005
approved these changes
Jan 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5597
Since list views can be stored out of order and because there can be nulls at the end of the vector, we have to calculate the length of the child vector by looking at all views in the vector.
Note that this does not take validity into account, as I have no idea if DuckDB allows for complete garbage in their list views if they are null. At least in Arrow, that is not allowed.
Also adds 3 regression tests.