-
Notifications
You must be signed in to change notification settings - Fork 113
feat[array]: use execute to return Canonical array not Vector pt2 #5905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
| // TODO(joe): take by value | ||
| Ok(decompress_into_array(array.clone()).to_canonical()) | ||
| fn execute(array: &Self::Array, ctx: &mut ExecutionCtx) -> VortexResult<Canonical> { | ||
| Ok(Canonical::Primitive(execute_decompress( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is execute_decompress a good fn name, given that execute has a particular meaning how it fits into the bigger picture? execute_decompress is just a one off inner fn. Not sure what I'm looking for here but execute_decompress suggests to me that this is a fn that is part of a pattern that is also used in other locations, which it isn't.
| // We need to drop ALPArray here in case converting encoded buffer into | ||
| // primitive didn't create a copy. In that case both alp_encoded and array | ||
| // will hold a reference to the buffer we want to mutate. | ||
| drop(array); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no more drop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you dont need ?
0ax1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 remarks
Merging this PR will degrade performance by 66.33%
Performance Changes
Comparing Footnotes
|
No description provided.