Skip to content

Conversation

@linzhe141
Copy link
Contributor

@linzhe141 linzhe141 commented Dec 9, 2025

according to this b1db66a#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R9

Summary by CodeRabbit

  • Chores
    • Simplified build configuration guidance with updated messaging for improved clarity.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 9, 2025

Walkthrough

The warning message displayed when temporary declaration files are missing has been updated in the rollup configuration. The suggested remediation command changed from executing multiple TypeScript project configurations to running a single configuration with the --noCheck flag.

Changes

Cohort / File(s) Summary
Configuration warning update
rollup.dts.config.js
Updated warning message text for missing temp dts files; revised suggested command from multiple TypeScript config runs to single config with --noCheck flag

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A message refined, a flag newly placed,
The warning now guides with a gentler face,
One command replaces the old tangled two,
Configuration wisdom, hopping on through! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating a warning message for missing temporary .d.ts files in rollup.dts.config.js, matching the file-level summary.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f51d3e2 and 28f94b1.

📒 Files selected for processing (1)
  • rollup.dts.config.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: test / e2e-test
🔇 Additional comments (1)
rollup.dts.config.js (1)

8-11: Warning text update matches the dts build workflow, just confirm env alignment

The new message is clear and correctly points developers to generate temp dts before running this script. Please just confirm that your local/build TypeScript setup actually uses tsc -p tsconfig.build.json --noCheck for this step so the guidance doesn’t drift from the real command.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 103 kB 39 kB 35.1 kB
vue.global.prod.js 161 kB 58.9 kB 52.6 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47 kB 18.3 kB 16.8 kB
createApp 55.1 kB 21.4 kB 19.6 kB
createSSRApp 59.4 kB 23.2 kB 21.1 kB
defineCustomElement 60.7 kB 23.1 kB 21.1 kB
overall 69.4 kB 26.6 kB 24.3 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 9, 2025

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14186
npm i https://pkg.pr.new/@vue/compiler-core@14186
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14186
npm i https://pkg.pr.new/@vue/compiler-dom@14186
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14186
npm i https://pkg.pr.new/@vue/compiler-sfc@14186
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14186
npm i https://pkg.pr.new/@vue/compiler-ssr@14186
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14186
npm i https://pkg.pr.new/@vue/reactivity@14186
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14186
npm i https://pkg.pr.new/@vue/runtime-core@14186
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14186
npm i https://pkg.pr.new/@vue/runtime-dom@14186
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14186
npm i https://pkg.pr.new/@vue/server-renderer@14186
yarn add https://pkg.pr.new/@vue/[email protected]

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14186
npm i https://pkg.pr.new/@vue/shared@14186
yarn add https://pkg.pr.new/@vue/[email protected]

vue

pnpm add https://pkg.pr.new/vue@14186
npm i https://pkg.pr.new/vue@14186
yarn add https://pkg.pr.new/[email protected]

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14186
npm i https://pkg.pr.new/@vue/compat@14186
yarn add https://pkg.pr.new/@vue/[email protected]

commit: 28f94b1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant