Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #192 where save_map() exports could ignore the width/height arguments, leading to inconsistent output dimensions. It does so by ensuring the widget’s size properties are set before the widget is serialized for headless rendering.
Changes:
- Update
save_map()to explicitly setmap$width/map$heightprior to callinghtmlwidgets::saveWidget(). - Clarify
width/heightdocumentation to state thatsave_map(width, height)overrides widget creation dimensions. - Regenerate/update related Rd documentation for
save_map()andprint_map().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| R/screenshot.R | Forces widget dimensions before saving HTML so exported PNG size matches save_map() args. |
| man/save_map.Rd | Updates parameter docs to reflect export-dimension override behavior. |
| man/print_map.Rd | Keeps inherited parameter docs consistent with the updated save_map() documentation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192.
Changes
save_map(), explicitly set widget properties beforesaveWidget().save_map(width, height)controls export dimensions.Test