Draft
fix: prevent "Bad state: Cannot add event after closing" in MdkVideoPlayer#391
Conversation
…oPlayer Co-authored-by: wang-bin <785206+wang-bin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unhandled exception in MdkVideoPlayer
fix: prevent "Bad state: Cannot add event after closing" in MdkVideoPlayer
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After
dispose()closes theStreamController, async and native callbacks can still fire and attempt to add events, throwingBad state: Cannot add event after closing.Changes
lib/src/video_player_mdk.dart— AddedstreamCtl.isClosedguards before everystreamCtl.add()andstreamCtl.addError()call:textureSize.then(...)async callback (the primary race: future resolves after dispose)onMediaStatuslistener —bufferingStart/bufferingEndeventsonEventlistener —bufferingUpdateeventonStateChangedlistener —completed/isPlayingStateUpdateeventscreate()error paths — media open failure and invalid video sizegetPosition()—bufferingUpdateeventEvents arriving after disposal are silently dropped rather than throwing.