Skip to content

minor improvement in refreshItemView function and set OnClickListener on TextView item #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mojtaba-yekta wants to merge 3 commits into
base: master
Choose a base branch
from
Open

minor improvement in refreshItemView function and set OnClickListener on TextView item #28

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c155b2
minor improvement in refreshItemView function
mojtaba-yekta Dec 12, 2018
db2015c
-
mojtaba-yekta Dec 12, 2018
161e932
set OnClickListener for TextView items so user can select item by tou…
mojtaba-yekta Dec 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 17 additions & 39 deletions app/src/main/java/com/wangjie/wheelview/WheelView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,21 +172,22 @@ public void startScrollerTask() {
private void initData() {
displayItemCount = offset * 2 + 1;

for (String item : items) {
views.addView(createView(item));
for (int i = 0; i < items.size(); i++) {
views.addView(createView(items.get(i), i - offset));
}

refreshItemView(0);
}

int itemHeight = 0;

private TextView createView(String item) {
private View createView(String item, int itemIndex) {
TextView tv = new TextView(context);
tv.setLayoutParams(new LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.WRAP_CONTENT));
tv.setSingleLine(true);
tv.setTextSize(TypedValue.COMPLEX_UNIT_SP, 20);
tv.setText(item);
tv.setTag(itemIndex);
tv.setGravity(Gravity.CENTER);
int padding = dip2px(15);
tv.setPadding(padding, padding, padding, padding);
Expand All @@ -197,6 +198,13 @@ private TextView createView(String item) {
LinearLayout.LayoutParams lp = (LinearLayout.LayoutParams) this.getLayoutParams();
this.setLayoutParams(new LinearLayout.LayoutParams(lp.width, itemHeight * displayItemCount));
}
tv.setOnClickListener(new OnClickListener() {
@Override
public void onClick(View v) {
int itemIndex = (int) v.getTag();
setSeletion(itemIndex);
}
});
return tv;
}

Expand Down Expand Up @@ -237,42 +245,12 @@ protected void onScrollChanged(int l, int t, int oldl, int oldt) {
}

private void refreshItemView(int y) {
int position = y / itemHeight + offset;
int remainder = y % itemHeight;
int divided = y / itemHeight;

if (remainder == 0) {
position = divided + offset;
} else {
if (remainder > itemHeight / 2) {
position = divided + offset + 1;
}

// if(remainder > itemHeight / 2){
// if(scrollDirection == SCROLL_DIRECTION_DOWN){
// position = divided + offset;
// Log.d(TAG, ">down...position: " + position);
// }else if(scrollDirection == SCROLL_DIRECTION_UP){
// position = divided + offset + 1;
// Log.d(TAG, ">up...position: " + position);
// }
// }else{
//// position = y / itemHeight + offset;
// if(scrollDirection == SCROLL_DIRECTION_DOWN){
// position = divided + offset;
// Log.d(TAG, "<down...position: " + position);
// }else if(scrollDirection == SCROLL_DIRECTION_UP){
// position = divided + offset + 1;
// Log.d(TAG, "<up...position: " + position);
// }
// }
// }

// if(scrollDirection == SCROLL_DIRECTION_DOWN){
// position = divided + offset;
// }else if(scrollDirection == SCROLL_DIRECTION_UP){
// position = divided + offset + 1;
}
int remainder = y % itemHeight;
int position = divided + offset;

if (remainder > itemHeight / 2)
position ++;

int childSize = views.getChildCount();
for (int i = 0; i < childSize; i++) {
Expand Down