Repository navigation
Conversation
… in AuthPolicyEditor
1 of 4 tasks
Contributor
Author
|
Could potentially address #2484 |
…ations # Conflicts: # warpgate-web/src/gateway/CredentialManager.svelte
…o 2D policy structure
… polling for approval removal
mtthsbrd
force-pushed
the
feature/auth-combinations
branch
from
October 23, 2026 19:23
b21bdc6 to
271ed1d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, protocol-level credential requirements only allow either "Anything" or a single conjunction (ANDed set) of credential requirements (e.g. Password AND TOTP). There was no way to specify alternative authentication pathways, such as allowing a user to authenticate via SSH using either SSH Key OR Password + TOTP OR Web In-Browser Approval. The previous UI also did not make credential combinations clear.
This PR introduces support for multiple authentication combinations per protocol (Disjunctive Normal Form: OR-of-ANDs), while preserving the "Allow any" option, paired with an interactive matrix UI in the web admin.
Key Changes
Core & Data Models:
UserRequireCredentialsPolicyprotocol fields (ssh,http,vnc,postgres,kubernetes,rdp) fromOption<Vec<CredentialKind>>toOption<Vec<Vec<CredentialKind>>>.Web Admin (Matrix UI):
AuthPolicyEditor.svelte:CredentialManager.svelteand user management views.API & Testing:
oasdiffseverity rule for the intentional schema evolution.AI Usage
Choose the level of AI involvement for this PR.
This is not to block AI contributions but rather to speed up PR review (saves time on trying to deduce the logic behind AI hallucinations).