Slash command menu sidecar.#9359
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I completed the review and posted feedback on this pull request. Comment I completed the review and posted feedback on this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR adds generic search item detail metadata and uses it to render a sidecar for truncated Cloud Mode v2 slash command menu rows.
Concerns
- No blocking correctness, security, error-handling, or performance concerns were found in the changed lines.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
There was a problem hiding this comment.
Overview
This PR adds generic search item detail plumbing and renders a sidecar for selected cloud-mode-v2 slash command menu items when the selected row appears truncated. The security pass did not identify data exposure, injection, or unsafe execution concerns in the changed code.
Concerns
- The truncation predicate does not match the actual slash command row layout when descriptions are present, so common rows with short command names and long descriptions can truncate without showing the sidecar.
- The sidecar overlay is positioned with unbounded window behavior, so it can render outside split panes or narrow windows and leave truncated content inaccessible.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
| match &detail.description { | ||
| Some(description) => { | ||
| let description_em = font_cache.em_width(appearance.ui_font_family(), font_size); | ||
| let description_px = description_em * description.chars().count() as f32; | ||
| (name_px + NAME_DESCRIPTION_GAP_PX + description_px) > available |
There was a problem hiding this comment.
InlineItem::render_item, so a short title plus long description can still truncate even when this sum fits. Use the same name-column width when computing description availability.
| OffsetPositioning::offset_from_save_position_element( | ||
| row_position_id, | ||
| vec2f(SIDECAR_GAP, 0.), | ||
| PositionedElementOffsetBounds::Unbounded, |
There was a problem hiding this comment.
Unbounded lets the sidecar render outside the window when the slash menu is near the right edge or in a narrow split, making the truncated text unreachable. Use window-bounded positioning so the sidecar shifts back on-screen.
| PositionedElementOffsetBounds::Unbounded, | |
| PositionedElementOffsetBounds::WindowByPosition, |
abhishekp106
force-pushed
the
abhishek/slash-command-menu-sidecar
branch
from
d5c1c0b to
80055bb
Compare
abhishekp106
force-pushed
the
abhishek/slash-command-menu
branch
from
9c0eb09 to
849517c
Compare
abhishekp106
force-pushed
the
abhishek/slash-command-menu-sidecar
branch
2 times, most recently
from
87c2dd6 to
9187f64
Compare
abhishekp106
force-pushed
the
abhishek/slash-command-menu
branch
from
21bc4dc to
a9aebec
Compare
abhishekp106
force-pushed
the
abhishek/slash-command-menu-sidecar
branch
from
9187f64 to
d767b46
Compare
abhishekp106
force-pushed
the
abhishek/slash-command-menu
branch
from
4066eb6 to
d8daf72
Compare
abhishekp106
force-pushed
the
abhishek/slash-command-menu-sidecar
branch
3 times, most recently
from
61db123 to
5769608
Compare
liliwilson
left a comment
liliwilson
left a comment
There was a problem hiding this comment.
Super cool!
Nit from previous PR that I noticed while testing this one:
On a shorter screen, the menu overflows and you can be highlighting things you can't select—can we make sure it stays in bounds and make it shorter if it needs to be?
abhishekp106
force-pushed
the
abhishek/slash-command-menu-sidecar
branch
from
5769608 to
6fff18b
Compare
abhishekp106
force-pushed
the
abhishek/slash-command-menu-sidecar
branch
from
6fff18b to
fd55110
Compare
|
Ack, will fix in a follow-up! |
2 participants
Description
Sidecar now works for the new slash command menu for cloud mode v2.
Testing
https://www.loom.com/share/6089946eae214fcb8f15c82c746d5d6b