Respect Markdown Viewer preference for Markdown file links

[maro20066600]

cargo test -p warp --lib notebooks::link::tests::test_open_markdown_file --features local_fs --no-run

[cla-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @maro20066600 on file. In order for us to review and merge your code, each contributor must visit https://cla.warp.dev to read and agree to our CLA. Once you have done so, please comment @cla-bot check to trigger another check.

[maro20066600]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[maro20066600]

CLA is signed now. This is ready for CI approval when a maintainer has a chance.

Local note: I ran formatting successfully and attempted the targeted test build in Codespaces, but the environment terminated rustc with SIGTERM before completion. The regression test is included for CI validation.

[oz-for-oss]

@maro20066600

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I reviewed this pull request and requested human review from: @kevinyang372.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR updates notebook Markdown file-link opening so the primary action respects the user's Markdown Viewer preference, falling back to the existing configured file target when the viewer is disabled. The tests initialize settings and cover both the default viewer-preferred path and the disabled-viewer path.

Concerns

• No blocking correctness or security concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[kevinyang372]

Thanks for contributing!

[kevinyang372]

@maro20066600 Can you fix the CI error here?

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: MARWAN.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[maro20066600]

@kevinyang372

Thanks for the heads up. I pushed a follow-up fix for the wasm clippy issue.

I also fixed the commit author email so the CLA check should pass again once it re-runs. The workflows now appear to be awaiting maintainer approval.

[maro20066600]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!