Drop unneeded fetch-depth: 0 from two workflows#9489
Open
sebryu wants to merge 1 commit intowarpdotdev:masterfrom
Open
Drop unneeded fetch-depth: 0 from two workflows#9489sebryu wants to merge 1 commit intowarpdotdev:masterfrom
sebryu wants to merge 1 commit intowarpdotdev:masterfrom
Conversation
The cleanup job in feature_flag_cleanup.yml only edits source files at HEAD; the agent prompt does not reference git history. The delete-release job in delete_release.yml only pushes HEAD to a renamed ref and deletes the old branch server-side. Neither needs the full repo history that fetch-depth: 0 forces. Removing it falls back to the action's default shallow clone, cutting checkout time on the warp repo without changing behavior.
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: @alokedesai. I left feedback as a comment so a maintainer can approve. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR removes fetch-depth: 0 from two GitHub Actions checkout steps where the changed jobs only need the checked-out commit rather than full repository history.
Concerns
- No blocking concerns found.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
captainsafia
added
the
external-contributor
Warp Dev Github Integration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two workflow checkouts request the full repo history via
fetch-depth: 0but never use it. Falling back to the default shallow clone speeds them up at no behavioral cost.Analysis
I scanned every
fetch-depth: 0site in.github/:check_approvals.yml:19git merge-base+git diffbetween base/headfilter: blob:none.create_release.yml:1623warpdotdev/generate-changelogfeature_flag_cleanup.yml:30(analyze)git blameofCargo.tomlfeature_flag_cleanup.yml:161(cleanup)feature_flag_cleanup.yml:218(create_pr)peter-evans/create-pull-requestpeter-evansonly requires deep history when it must include prior local commits. Worth a follow-up.delete_release.yml:95git push HEAD:refs/heads/<new>thengit push --delete <old>Changes
feature_flag_cleanup.yml— removedfetch-depth: 0from the cleanup job. The Oz agent edits source files at HEAD; no git history operations occur in the prompt.delete_release.yml— removedfetch-depth: 0from the delete job. Renaming a branch is two server-side pushes; only the tip commit is needed.Test plan
feature_flag_cleanup.ymlsucceeds end-to-end (analyze → cleanup → create_pr).delete_release.ymlinvocation succeeds (rename + delete).