Skip to content

dont log tool call result errors as error level#9495

Merged
acarl005 merged 1 commit intomasterfrom
andy/demote-tool-call-error-to-warn
Apr 30, 2026
Merged

dont log tool call result errors as error level#9495
acarl005 merged 1 commit intomasterfrom
andy/demote-tool-call-error-to-warn

Conversation

@acarl005
Copy link
Copy Markdown
Contributor

Description

As discussed, this is deemed not severe enough for error level.

@acarl005 acarl005 requested a review from zachbai April 29, 2026 21:11
@cla-bot cla-bot Bot added the cla-signed label Apr 29, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Apr 29, 2026

@acarl005

I'm starting a first review of this pull request.

I completed the review and posted feedback on this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR demotes the diagnostic emitted when a tool call result has no matching tool call in task context from error level to warning level, and updates the nearby documentation comment accordingly.

Concerns

  • No blocking correctness, security, error-handling, or performance concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@acarl005 acarl005 merged commit cca4346 into master Apr 30, 2026
49 of 51 checks passed
@acarl005 acarl005 deleted the andy/demote-tool-call-error-to-warn branch April 30, 2026 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants