consolidate powershell history loading errors#9499
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and posted feedback on this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR downgrades the local log for recoverable PowerShell history-loading failures to a warning and, when crash reporting is enabled, emits a consolidated Sentry error event with structured PowerShell failure context after the async_fs fallback succeeds.
Concerns
- No blocking correctness, error-handling, or security concerns found in the changed diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
danielpeng2
approved these changes
May 1, 2026
sypsyp97
added a commit
to sypsyp97/warp
that referenced
this pull request
May 2, 2026
…pdotdev#9499 partial) When PowerShell can't read history but async_fs::read succeeds, the fallback path is recoverable — log::error was too loud for what is now a healed condition. Take only the log-level downgrade; the upstream PR also adds a sentry::capture_message under #[cfg(feature = "crash_reporting")] which slim ripped out earlier (see c61f195), so that block is N/A. Comment-reflow noise from the upstream diff is also skipped. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from warpdotdev/warp-internal#25021 via
script/migrate-private-to-public.Commits