-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
CI: Extract and don't hardcode artifact naming #3463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cprecioso
wants to merge
1
commit into
main
Choose a base branch
from
cprecioso/separate-workflows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6268ab3 to
a8b09b5
Compare
Deploying wasp-docs-on-main with
|
| Latest commit: |
10f3781
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2067bece.wasp-docs-on-main.pages.dev |
| Branch Preview URL: | https://cprecioso-separate-workflows.wasp-docs-on-main.pages.dev |
e6a39bd to
3eff1c1
Compare
3eff1c1 to
be4e42f
Compare
be4e42f to
23209a6
Compare
23209a6 to
e0ad7c1
Compare
e0ad7c1 to
89d55e7
Compare
89d55e7 to
6ad9ba9
Compare
6ad9ba9 to
4ab3cb2
Compare
4ab3cb2 to
4ae72a3
Compare
4ae72a3 to
6ab98fc
Compare
6ab98fc to
afd026c
Compare
afd026c to
10f3781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
waspc-buildworkflow, so that we can reuse it in multiple places (mainly, thefetch-nightly-packages; and in the future the npm packaging script) without repeating ourselves.Type of change
Checklist
I tested my change in a Wasp app to verify that it works as intended.
🧪 Tests and apps:
examples/kitchen-sink/e2e-tests.waspc/data/Cli/templates, as needed.examples/, as needed.examples/tutorials) I updated the tutorial in the docs (and vice versa).📜 Documentation:
web/docs/.🆕 Changelog: (if change is more than just code/docs improvement)
waspc/ChangeLog.mdwith a user-friendly description of the change.web/docs/migration-guides/.versioninwaspc/waspc.cabalto reflect the changes I introduced.