Skip to content

Conversation

@cprecioso
Copy link
Member

@cprecioso cprecioso commented Dec 1, 2025

Description


  • I extracted the computation of the artifact and tarball name out of the waspc-build workflow, so that we can reuse it in multiple places (mainly, the fetch-nightly-packages; and in the future the npm packaging script) without repeating ourselves.
  • Makes the waspc-build job output the computed names of the artifacts it has created. This way we don't hardcode these names in the following workflows.
    • This requires a bit of a workaround since, in matrix jobs, each job will override the output. Instead, we store each job's output in a different variable.

Type of change

  • 🔧 Just code/docs improvement
  • 🐞 Bug fix
  • 🚀 New/improved feature
  • 💥 Breaking change

Checklist

  • I tested my change in a Wasp app to verify that it works as intended.

  • 🧪 Tests and apps:

    • I added unit tests for my change.
    • (if you fixed a bug) I added a regression test for the bug I fixed.
    • (if you added/updated a feature) I added/updated e2e tests in examples/kitchen-sink/e2e-tests.
    • (if you added/updated a feature) I updated the starter templates in waspc/data/Cli/templates, as needed.
    • (if you added/updated a feature) I updated the example apps in examples/, as needed.
      • (if you updated examples/tutorials) I updated the tutorial in the docs (and vice versa).
  • 📜 Documentation:

    • (if you added/updated a feature) I added/updated the documentation in web/docs/.
  • 🆕 Changelog: (if change is more than just code/docs improvement)

    • I updated waspc/ChangeLog.md with a user-friendly description of the change.
    • (if you did a breaking change) I added a step to the current migration guide in web/docs/migration-guides/.
    • I bumped the version in waspc/waspc.cabal to reflect the changes I introduced.

@cprecioso cprecioso self-assigned this Dec 1, 2025
@cprecioso cprecioso changed the title WIP cprecioso/extract naming Dec 1, 2025
@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from 6268ab3 to a8b09b5 Compare December 1, 2025 15:38
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 1, 2025

Deploying wasp-docs-on-main with  Cloudflare Pages  Cloudflare Pages

Latest commit: 10f3781
Status: ✅  Deploy successful!
Preview URL: https://2067bece.wasp-docs-on-main.pages.dev
Branch Preview URL: https://cprecioso-separate-workflows.wasp-docs-on-main.pages.dev

View logs

@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from e6a39bd to 3eff1c1 Compare December 1, 2025 16:37
@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from 3eff1c1 to be4e42f Compare December 1, 2025 16:50
@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from be4e42f to 23209a6 Compare December 2, 2025 08:44
@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from 23209a6 to e0ad7c1 Compare December 2, 2025 09:10
@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from e0ad7c1 to 89d55e7 Compare December 2, 2025 09:10
@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from 89d55e7 to 6ad9ba9 Compare December 2, 2025 09:21
@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from 6ad9ba9 to 4ab3cb2 Compare December 2, 2025 09:35
@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from 4ab3cb2 to 4ae72a3 Compare December 2, 2025 09:49
@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from 4ae72a3 to 6ab98fc Compare December 2, 2025 10:30
@cprecioso cprecioso changed the title cprecioso/extract naming CI: Extract and don't hardcode artifact naming Dec 2, 2025
@cprecioso cprecioso marked this pull request as ready for review December 2, 2025 11:00
@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from 6ab98fc to afd026c Compare December 3, 2025 13:26
@cprecioso cprecioso force-pushed the cprecioso/separate-workflows branch from afd026c to 10f3781 Compare December 3, 2025 14:01
@cprecioso cprecioso requested a review from sodic December 4, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants