Skip to content

Conversation

@infomiho
Copy link
Member

@infomiho infomiho commented Dec 5, 2025

Description

Quick refactor since we no longer need to keep the server auth deps in the SDK package.json ever since we introduced npm workspaces.

Type of change

  • 🔧 Just code/docs improvement
  • 🐞 Bug fix
  • 🚀 New/improved feature
  • 💥 Breaking change

Checklist

  • I tested my change in a Wasp app to verify that it works as intended.

  • 🧪 Tests and apps:

    • I added unit tests for my change.
    • (if you fixed a bug) I added a regression test for the bug I fixed.
    • (if you added/updated a feature) I added/updated e2e tests in examples/kitchen-sink/e2e-tests.
    • (if you added/updated a feature) I updated the starter templates in waspc/data/Cli/templates, as needed.
    • (if you added/updated a feature) I updated the example apps in examples/, as needed.
      • (if you updated examples/tutorials) I updated the tutorial in the docs (and vice versa).
  • 📜 Documentation:

    • (if you added/updated a feature) I added/updated the documentation in web/docs/.
  • 🆕 Changelog: (if change is more than just code/docs improvement)

    • I updated waspc/ChangeLog.md with a user-friendly description of the change.
    • (if you did a breaking change) I added a step to the current migration guide in web/docs/migration-guides/.
    • I bumped the version in waspc/waspc.cabal to reflect the changes I introduced.

@infomiho infomiho deployed to fly-deploy-test December 5, 2025 11:22 — with GitHub Actions Active
@infomiho
Copy link
Member Author

infomiho commented Dec 6, 2025

The comment says:

-- Server auth deps must be installed in the SDK because "@lucia-auth/adapter-prisma"
-- lists prisma/client as a dependency.
-- Installing it inside .wasp/out/server/node_modules would also
-- install prisma/client in the same folder, which would cause our
-- runtime to load the wrong (uninitialized prisma/client).

After I moved the deps from SDK to server, the same problem happened but in a different place.

The old problem was that we had the server package and the SDK package which would both install @prisma/client. We got rid of the server install by moving its auth deps to the SDK.

The new problem is similar, the server is now part of the npm workspace, so its deps get installed in the root project. But we still have the SDK which is outside of the npm workspace and we still have two instances of @prisma/client.

I believe these deps should be moved to the server deps after the SDK becomes a part of the workspaces. This issue won't happen then. Check out #3233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants