fix(shared): support extra header aliases in model init config#2287
Merged
fix(shared): support extra header aliases in model init config#2287
Conversation
Deploying midscene with
|
| Latest commit: |
4825a4f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://babd94fe.midscene.pages.dev |
| Branch Preview URL: | https://codex-fix-model-extra-header.midscene.pages.dev |
ottomao
approved these changes
Apr 7, 2026
quanru
force-pushed
the
codex/fix-model-extra-headers
branch
from
9992fac to
4c4f0c5
Compare
quanru
force-pushed
the
codex/fix-model-extra-headers
branch
from
4825a4f to
6f0c9b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The Python OpenAI SDK uses
extra_headersto attach custom HTTP headers, while the Node.js OpenAI SDK usesdefaultHeaders. Many model providers show Python examples in their docs, so users naturally copyextra_headersintoMIDSCENE_MODEL_INIT_CONFIG_JSON. Since Midscene uses the Node.js SDK,extra_headersis silently ignored — the headers are never sent and auth fails without any error.What this PR does
validateOpenaiExtraConfigstep that throws a clear error whenextra_headersorextraHeadersis detected, telling the user to usedefaultHeadersinstead.Validation
pnpm run lintnpx nx test @midscene/sharedCloses #2212