fix(parser): ! in neg. operators mistranslated to dots#28
Open
koubas wants to merge 1 commit intowebantic:masterfrom
Open
fix(parser): ! in neg. operators mistranslated to dots#28koubas wants to merge 1 commit intowebantic:masterfrom
koubas wants to merge 1 commit intowebantic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internally, dots were temporarily translated to exclamation marks and back.
When the exclamation marks were replaced back to dots, even the literal ones from the source, like the ones in negated operators, were unintentionally replaced:
I fixed that by choosing a less ambiguous replacement token (
<_DOT_TOKEN_>) instead of the exclamation mark.