Report API-mutation grants in transcript and improve handling - #2712
Merged
Conversation
The composer badge used to be the standing signal that POST/PUT/PATCH/DELETE were allowed for a tab. With it gone, the /allow-api parser was the only path that told the user anything, and the retry button granted silently. That mattered after a panel reopen: the in-memory apiMutationsAllowedByTab map is wiped, but the cached transcript comes back with its retry buttons intact. Clicking Retry re-enabled mutations for the whole tab conversation with nothing on screen. Both call sites now go through grantApiMutationsForTab(), which sets the flag and emits the confirmation bubble together. A test pins the invariant: exactly one direct setApiMutationsAllowedForTab(..., true) call per build, inside the helper. The bubble still lands in whichever transcript is rendered, so a slash command aimed at a background tab reports into the wrong conversation. That predates this change; the comment on the helper now says so instead of claiming an invariant that does not hold. Also guards two indexOf anchors in test/run.js that were used as slice bounds without a -1 check, including one added here that passed vacuously in exactly the case it was meant to catch. The persistent alwaysAllowApiMutations setting still has no in-panel indicator. Fixing that means either restoring a badge or accepting a stale, misrouted transcript message, so it is left alone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Report every API-mutation grant in the transcript
|
@esokullu is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.