-
-
Notifications
You must be signed in to change notification settings - Fork 1
fix(dioxus): preserve undefined in execute() via __wdio_value__ envelope #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undefinedfor any non-envelope object in non-embedded contextsunwrapEmbeddedResultreturnsundefinedfor ANY plain object that lacks__wdio_value__, not just the serialized-undefined empty envelope{}. This is correct whenbrowser.executeis always routed through the embedded Dioxus polling loop (which guarantees the envelope). However, the string-script overload ofexecutecarries no such guarantee — the file header documents it as providing "standard WDIO behaviour where the body is wrapped asfunction() { ${body} }", implying it can be called against a non-embedded WebDriver. If that path is ever exercised and the script returns a plain object (e.g.,{ x: 1 }),unwrapEmbeddedResultwould fall into the key-absent branch and silently returnundefinedinstead of the actual value. Adding an explicit guard (e.g., checkingObject.keys(envelope).length === 0for the empty-envelope case, or only applyingunwrapEmbeddedResultwhen the embedded bridge is known to be active) would make the assumption explicit and prevent silent corruption.