Skip to content

chore(ci): serialize E2E test runs across PRs#678

Open
bhabalan wants to merge 2 commits intowebex:nextfrom
bhabalan:chore/e2e-concurrency-serialization
Open

chore(ci): serialize E2E test runs across PRs#678
bhabalan wants to merge 2 commits intowebex:nextfrom
bhabalan:chore/e2e-concurrency-serialization

Conversation

@bhabalan
Copy link
Copy Markdown
Contributor

@bhabalan bhabalan commented Apr 26, 2026 •
edited
Loading

COMPLETES #CAI-7862

This pull request addresses

E2E test suites (meetings and cc-widgets) currently run in parallel across different PRs. Since these tests hit shared infrastructure (Playwright sandbox, entry points), concurrent runs can cause flaky failures and resource contention.

by making the following changes

Added job-level concurrency groups to each E2E job in the Pull Request CI workflow:

  • e2e_test_meetings → concurrency group e2e-meetings
  • e2e_test_cc_widgets → concurrency group e2e-cc-widgets

Both use cancel-in-progress: false so that a queued run waits for the currently running one to finish rather than canceling it.

Behavior summary:

Scenario Before After
New push to same PR Cancels older run ✓ Cancels older run ✓ (unchanged)
E2E from different PRs Run in parallel Serialized per suite — newer waits
Meetings vs CC-widgets Independent Still independent (separate groups)

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • Verified YAML syntax is valid
  • The testing is done with the amplify link

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Claude Code
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

@bhabalan
chore(ci): serialize E2E test runs across PRs
366ad7d 
Add job-level concurrency groups to E2E jobs so that each suite
(meetings, cc-widgets) runs one at a time across different PRs.
Within the same PR, older runs are still canceled by the existing
workflow-level concurrency group.
@bhabalan bhabalan marked this pull request as ready for review April 26, 2026 16:32
@bhabalan bhabalan requested a review from a team as a code owner April 26, 2026 16:32
@bhabalan
Copy link
Copy Markdown
Contributor Author

bhabalan commented Apr 26, 2026

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

chatgpt-codex-connector Bot commented Apr 26, 2026

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@aws-amplify-us-east-2
Copy link
Copy Markdown

aws-amplify-us-east-2 Bot commented Apr 26, 2026

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-678.d1b38q61t1z947.amplifyapp.com

@bhabalan bhabalan added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Apr 27, 2026
Shreyas281299
Shreyas281299 approved these changes Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Shreyas281299 Shreyas281299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. Can you add some proof of this working.

@bhabalan
Copy link
Copy Markdown
Contributor Author

bhabalan commented May 5, 2026

Proof of Concurrency Serialization

Tested on my fork by opening two PRs with the run_e2e label simultaneously, after merging the concurrency change into the base branch (next).

Setup

Results — E2E Jobs Serialized (not cancelled)

Concurrency Group PR Started (UTC) Completed (UTC) Observation
e2e-cc-widgets PR 2 (first) 04:30:28 04:34:15 Ran immediately
e2e-cc-widgets PR 1 (queued) 04:34:17 in_progress Started 2s after PR 2 finished
e2e-meetings PR 2 (first) 04:30:22 04:31:51 Ran immediately
e2e-meetings PR 1 (queued) 04:31:59 04:33:28 Started 8s after PR 2 finished

Conclusion

PR 1's E2E jobs entered a pending (waiting) state and only started after PR 2's corresponding E2E jobs completed. This confirms cancel-in-progress: false serializes concurrent E2E runs across PRs rather than cancelling them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shreyas281299 Shreyas281299 Shreyas281299 approved these changes

@eigengravy eigengravy eigengravy approved these changes

Assignees

No one assigned

Labels

run_e2e Add this label to run E2E test for meeting and CC widgets validated Indicates that the PR is ready for actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bhabalan @Shreyas281299 @eigengravy