Update: Bump Doctrine to ORM 3 and collections 2 (Case 212955) - #26
Merged
Conversation
Doctrine ORM 3 removed the annotation driver (handled in prep package B) and requires the entity mappings to be declared explicitly (handled in prep package C). With those in place, raise doctrine/orm to ^3.0 and doctrine/collections to ^2.0. This also pulls in DBAL 4 and persistence 4 as transitive upgrades. The MappedSuperclass mapping and all repositories compile unchanged; Collection/ArrayCollection usage required no changes (generics only). One code fix was needed: AppClassTemplatesTest constructed its EntityManager by passing EventManager to DriverManager::getConnection(), which DBAL 4 no longer accepts. Move the EventManager to the EntityManager constructor instead, which is the correct API in ORM 3 / DBAL 4.
janopae
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doctrine ORM 3 removed the annotation driver (handled in fce9de9) and requires the entity mappings to be declared explicitly (handled in 34cc2b5). With those in place, raise
doctrine/ormto^3.0anddoctrine/collectionsto^2.0. This also pulls in DBAL 4 and persistence 4 as transitive upgrades. The MappedSuperclass mapping and all repositories compile unchanged;Collection/ArrayCollectionusage required no changes (generics only).One code fix was needed:
AppClassTemplatesTestconstructed itsEntityManagerby passingEventManagertoDriverManager::getConnection(), which DBAL 4 no longer accepts. Move theEventManagerto theEntityManagerconstructor instead, which is the correct API in ORM 3 / DBAL 4.