Skip to content

fix: folder permissions transfer - #33

Merged
brunozoric merged 4 commits into
mainfrom
bruno/fix/folder-permissions-transfer
Aug 26, 2026
Merged

fix: folder permissions transfer#33
brunozoric merged 4 commits into
mainfrom
bruno/fix/folder-permissions-transfer

Conversation

@brunozoric

Copy link
Copy Markdown
Contributor

Summary

  • Extract stripRevision helper in updateFlpIds transformer to strip any #NNNN revision suffix (not just #0001)
  • Strip revision suffix from inheritedFrom field inside data.permissions array
  • Add tests covering permissions stripping, arbitrary 4-digit revisions, missing inheritedFrom, and missing permissions array
  • Update dependencies

Test plan

  • yarn full passes (format, lint, typecheck, 719 tests)
  • updateFlpIds coverage at 95% (up from 61%)
  • Verified inheritedFrom values like parent:abc123#0001 become parent:abc123
  • Verified non-#0001 suffixes like #0010, #0042, #0099 are also stripped
  • Verified records without permissions array don't throw
  • Verified permissions without inheritedFrom are skipped

brunozoric and others added 4 commits August 26, 2026 12:16
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…uffix

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@brunozoric brunozoric self-assigned this Aug 26, 2026
@brunozoric
brunozoric merged commit 2acdc84 into main Aug 26, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant