fix: bypass client cache to fix cross-account migration - #39
Merged
Conversation
…on (#30) The cache in @webiny/aws-sdk hashes config objects with createCacheKey, which serializes credential-provider functions to the same key. When source and target use different AWS profiles (fromAwsProfile), the target client was reusing the source's cached client. - DynamoDbClient: create DynamoDBClient/DynamoDBDocument directly instead of using getDocumentClient (which has no cache-bypass option) - S3Client: pass cache: false to createS3Client Closes #30 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ders Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@webiny/aws-sdk'sgetDocumentClientandcreateS3Clientcache clients by a hash of their config. Whencredentialsis a function (e.g.fromAwsProfile), the hash is identical for source and target — so the target silently reuses the source's client.getDocumentClientwith directDynamoDBClient+DynamoDBDocument.from()construction (no cache bypass option exists)cache: falsetocreateS3Client(supported by the API)Closes #30
Test plan
yarn fullpasses (719 tests)convertEmptyValues,removeUndefinedValues,convertClassInstanceToMap)🤖 Generated with Claude Code