Skip to content

fix: add webpack ignore to posthog-js #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brunozoric wants to merge 1 commit into from
Closed

fix: add webpack ignore to posthog-js #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@
"lint": "oxlint --deny-warnings",
"lint:fix": "oxlint --fix"
},
"dependencies": {
"posthog-js": "^1.376.4"
},
"devDependencies": {
"@testing-library/dom": "^10.4.1",
"@testing-library/react": "^16.3.2",
Expand All @@ -58,21 +61,16 @@
"happy-dom": "^20.9.0",
"oxfmt": "^0.52.0",
"oxlint": "^1.67.0",
"posthog-js": "^1.376.4",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"tsx": "^4.22.3",
"typescript": "^6.0.3",
"vitest": "^4.1.7"
},
"peerDependencies": {
"posthog-js": ">=1.376.4",
"react": ">=18"
},
"peerDependenciesMeta": {
"posthog-js": {
"optional": true
},
"react": {
"optional": true
}
Expand Down
3 changes: 1 addition & 2 deletions src/web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ export interface WebClientConfig extends ClientConfig {
distinctId?: string;
/**
* Opt-in PostHog browser-side session recording. When omitted, posthog-js is not
* loaded — consumers that don't enable recording pay zero bundle cost. Consumers
* that do enable it must install `posthog-js` (declared as an optional peer dep).
* loaded — consumers that don't enable recording pay zero bundle cost.
*/
sessionRecording?: SessionRecordingConfig;
/** Number of retry attempts for transient HTTP errors. Defaults to 3. */
Expand Down
3 changes: 0 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1224,11 +1224,8 @@ __metadata:
typescript: "npm:^6.0.3"
vitest: "npm:^4.1.7"
peerDependencies:
posthog-js: ">=1.376.4"
react: ">=18"
peerDependenciesMeta:
posthog-js:
optional: true
react:
optional: true
languageName: unknown
Expand Down
Loading