feat: make Promise and PromiseAdapter generic over the adopted promise type

[simPod]

Problem

GraphQL\Executor\Promise\Promise documents $adoptedPromise with a @var union naming every supported platform type, which requires importing both Amp\Future and Amp\Promise:

/** @var SyncPromise|ReactPromise<mixed>|AmpFuture<mixed>|AmpPromise<mixed> */
public $adoptedPromise;

amphp/amp v2 ships Amp\Promise and v3 ships Amp\Future, so on any single installation one of those classes does not exist. Because the property is read by consumers, static analysis resolves the whole union and crashes on the missing class — e.g. PHPStan:

Internal error: Class Amp\Promise was not found while trying to analyse it

Change

Make Promise and PromiseAdapter generic over TAdopted, with each adapter binding the concrete platform type:

• SyncPromiseAdapter → PromiseAdapter<SyncPromise>
• ReactPromiseAdapter → PromiseAdapter<React\Promise\PromiseInterface<mixed>>
• AmpFutureAdapter → PromiseAdapter<Amp\Future<mixed>>
• AmpPromiseAdapter → PromiseAdapter<Amp\Promise<mixed>>

Promise no longer names any optional platform class, so it analyses cleanly regardless of which promise library is installed. The adapters gain @phpstan-return Promise<T> annotations and shed now-redundant assert()/instanceof guards; adapter tests drop assertInstanceOf assertions the generics make statically provable.

TAdopted defaults to mixed, so existing bare Promise/PromiseAdapter references are unchanged — not a BC break.

[Copilot]

Pull request overview

This PR adjusts the GraphQL\Executor\Promise\Promise PHPDoc to reference Amp types via fully-qualified names instead of use imports, preventing static analyzers from failing symbol discovery when only one of Amp\Promise (v2) or Amp\Future (v3) exists (or Amp isn’t installed).

Changes:

• Removed use Amp\Future / use Amp\Promise imports that may reference non-installed symbols.
• Updated the $adoptedPromise @var union to use \Amp\Future and \Amp\Promise as FQNs.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

src/Executor/Promise/Adapter/AmpFutureAdapter.php:52

• then() no longer validates that the wrapped value is an Amp\Future. If a Promise from a different adapter is passed in, $future->await() will fatal instead of producing a controlled InvariantViolation.

    public function then(Promise $promise, ?callable $onFulfilled = null, ?callable $onRejected = null): Promise
    {
        $future = $promise->adoptedPromise;

        $next = async(static function () use ($future, $onFulfilled, $onRejected) {
            try {
                $value = $future->await();
            } catch (\Throwable $reason) {

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/Executor/Promise/Promise.php:34

• Promise is generic over TAdopted, but the stored adapter is not typed as PromiseAdapter<TAdopted>. Without binding the adapter to the same template, static analysis can’t verify that $this->adapter->then($this, ...) actually returns Promise<TAdopted>, and it also permits constructing Promise<TAdopted> with a mismatched adapter type.

    private PromiseAdapter $adapter;

    /**
     * @phpstan-param TAdopted $adoptedPromise
     *
     * @throws InvariantViolation
     */
    public function __construct($adoptedPromise, PromiseAdapter $adapter)

[Copilot]

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

[spawnia]

Looks good overall, happy to do a final review and merge once CI passes.

[simPod]

I tried to fiddle with one more thing but I'll skip it for now. CI is green.

[spawnia]

Thanks @simPod, released with https://github.com/webonyx/graphql-php/releases/tag/v15.34.0.