Open
Conversation
Signed-off-by: George Hafiz <[email protected]>
…into whitelisting
…into whitelisting
…into whitelisting
…into whitelisting
…into whitelisting
…into whitelisting
…ng to 'hide original'. Signed-off-by: George Hafiz <[email protected]>
… more central. Signed-off-by: George Hafiz <[email protected]>
Signed-off-by: George Hafiz <[email protected]>
…into whitelisting Conflicts: extension/options.html extension/options.js extension/preferences.js extension/webpg_results.js Resolved to take new class design from upstream but maintain additions such as options tabs and whitelisting. Signed-off-by: George Hafiz <[email protected]>
… continue method definitions). Signed-off-by: George Hafiz <[email protected]>
If test logic - platform should be set exclusively. Signed-off-by: George Hafiz <[email protected]>
- Don't auto unique the exceptions lists, let the user worry about that. - Validate the URI a bit, reject nonsense URIs (eg ftp://). - Load existing user exceptions when starting up. Signed-off-by: George Hafiz <[email protected]>
REGRESSION WARNING: WebPG no longer rechecks the page for PGP to parse on SCROLL event. The way it's currently implemented makes it bypass exceptions checking. Signed-off-by: George Hafiz <[email protected]>
Member
|
@deed02392 - I have finally returned from my assignment and I have done a cursory review of your pull request. I will discuss with you the particulars of any issues I have within the individual commits to preserve context. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a request to merge a whitelisting branch into your upstream, so you can use your own repos to check my implementation.
Kyle please give your feedback on the on scroll parsing, I think we need to think about another way of doing that so that it follows the same logic paths as a page load (hence not bypassing exception checking) - that is if you agree with my choice on where to check for exceptions against the URI.
Todo:
Make it pretty
Reconsider 'on scroll' parsing of the page
Wildcarding
Done:
Three filtering modes, off, only if whitelisted, stop if blacklisted
Working based on an exact URI match