Fix C++ event window lookup and Linux WebKit navigation handling; update serve_a_folder example#685
Merged
AlbertShown merged 3 commits intowebui-dev:mainfrom Feb 18, 2026
Merged
Conversation
AlbertShown
approved these changes
Feb 18, 2026
Member
|
Thank you @triuk, useful contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes three follow-up changes after the member-function bind support:
C++ API fix for the b36c04e:
event::get_window()now resolves the window usingbind_id(notwindow), preventing invalid callback-window lookups.Linux/WebKit navigation fix:
webui_navigate()Linux WebView path now goes throughwebui_show(window, url)to avoid navigation re-entrancy crashes when called from all-events navigation handlers.Example updates:
examples/C++/serve_a_folderwas refactored to a class-based style using member-function binding.serve_a_folderto CMake examples target registration.Validation
serve_a_foldertarget).OpenNewWindowworks,SwitchToSecondPageworks,