refactor: extract shared facade-activation and iframe-registry composables - #21
Merged
Conversation
Share the facade-holds-a-live-iframe tracking (useFacadeActivation) and the per-key iframe bind-once/park/restore lifecycle (useFrameRegistry) across the three platform carousels. Add a happy-dom unit test covering both composables and the pure park/restore helpers; vue added as a devDependency so the composables' Vue imports resolve under vitest.
sagar-kap
force-pushed
the
refactor/shared-embed-state
branch
from
August 7, 2026 10:13
643e0d6 to
ddfbbe2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the duplicated facade-activation and iframe park/restore lifecycle from the three platform carousels into two composables:
useFacadeActivation— Set-based facade↔iframe tracking shared by YouTube (id-keyed) and TikTok (index-keyed).useFrameRegistry— per-key iframe bind-once + park/restore/parkAll/restoreAll (about:blank+dataset.savedSrc), used by all three carousels.Adds
test/embed-state.test.ts(happy-dom) covering both composables and the pureparkFrame/restoreFramehelpers.vueadded as a devDependency so the composables' Vue imports resolve under Vitest.