Skip to content

common: Send roomPath and roomOrigin to rtcstats-server as query param - #1185

Open
misi-whereby wants to merge 2 commits into
mainfrom
misi/cob-3434-add-sdk-to-send-roomorigin-query-param
Open

misi-whereby wants to merge 2 commits into
mainfrom
misi/cob-3434-add-sdk-to-send-roomorigin-query-param

Conversation

@misi-whereby

@misi-whereby misi-whereby commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Description

Summary:
Send query param roomUrl to rtcstats-server

Related Issue:

Testing

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Additional Information

@changeset-bot

changeset-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bdb6e4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@whereby.com/core Patch
@whereby.com/media Minor
@whereby.com/assistant-sdk Patch
@whereby.com/browser-sdk Patch
@whereby.com/react-native-sdk Patch
@whereby.com/audio-denoiser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@misi-whereby misi-whereby changed the title Send roomPath and roomOrigin to rtcstats-server as query param common: Send roomPath and roomOrigin to rtcstats-server as query param Nov 10, 2026
@misi-whereby
misi-whereby force-pushed the misi/cob-3434-add-sdk-to-send-roomorigin-query-param branch from a0bd617 to eacadbd Compare November 10, 2026 17:46
@misi-whereby
misi-whereby requested a review from a team November 11, 2026 15:03
@misi-whereby
misi-whereby force-pushed the misi/cob-3434-add-sdk-to-send-roomorigin-query-param branch 3 times, most recently from 83a5269 to bdb6e4c Compare November 13, 2026 07:49
rtcstats connects with the page's path, and the server uses it as the room
name. The server also uses the Origin header for the subdomain, and both in
the stored file name. On a page that isn't the room's page, these are the
page's, and a page can't set the Origin header.

setRoomUrl() takes the room's origin and path: the connection then uses an
empty path, so the page's path isn't sent, and the room's origin and path
are sent in the roomUrl query parameter, for a server that reads it. It's
used from the next connection. Without it, the URL is the same as before.

After requireRoomUrl(), rtcstats doesn't connect while the room's URL isn't
set, so the page's origin and path are never sent.
rtcstats uses the page's path as the room name, and the page's origin for
the subdomain, and both in the stored file name. Core doesn't run on the
room's page, so it gives rtcstats the room's origin and path when the app
starts, and clears them when the app stops. The room URL's query isn't
passed on, as it can hold a room key.
@misi-whereby
misi-whereby force-pushed the misi/cob-3434-add-sdk-to-send-roomorigin-query-param branch from bdb6e4c to 2df89b2 Compare November 17, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants