Repository navigation
core: Fix bug in rtcstats customEvent:userRole - #1187
Open
misi-whereby wants to merge 6 commits into
Open
misi-whereby wants to merge 6 commits into
misi-whereby wants to merge 6 commits into
Conversation
🦋 Changeset detectedLatest commit: fc97977 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
misi-whereby
force-pushed
the
misi/cob-3427-rtcstats-receives-the-user-role-under-the
branch
3 times, most recently
from
November 13, 2026 08:01
f5d1358 to
38ad47e
Compare
rtcstats connects with the page's path, and the server uses it as the room name. The server also uses the Origin header for the subdomain, and both in the stored file name. On a page that isn't the room's page, these are the page's, and a page can't set the Origin header. setRoomUrl() takes the room's origin and path: the connection then uses an empty path, so the page's path isn't sent, and the room's origin and path are sent in the roomUrl query parameter, for a server that reads it. It's used from the next connection. Without it, the URL is the same as before. After requireRoomUrl(), rtcstats doesn't connect while the room's URL isn't set, so the page's origin and path are never sent.
rtcstats uses the page's path as the room name, and the page's origin for the subdomain, and both in the stored file name. Core doesn't run on the room's page, so it gives rtcstats the room's origin and path when the app starts, and clears them when the app stops. The room URL's query isn't passed on, as it can hold a room key.
No behaviour change. doRtcAnalyticsCustomEventsInitialize and the action listener had their own copies of the compare, send and mark logic. Both now use sendIfChanged, which the next commit also uses from reactors.
clientId, deviceId, externalId, organizationId, signalConnectionStatus, rtcConnectionStatus and userRole were only sent by doRtcAnalyticsCustomEventsInitialize, when the RtcManager is initialized. Later changes, such as a signal disconnect or reconnect, weren't sent unless another RtcManager was initialized. Each is now also sent when its value changes. Values are only sent once the RtcManager is initialized. doRtcAnalyticsCustomEventsInitialize runs then and sends insightsStats first, which rtcstats uses to set the session's timestamp. Checking only that an RtcManager existed wasn't enough: rtcManagerCreated sets the RtcManager and status "ready" in the same action, before the initialization. Values that change before it are left unmarked, and the initialization sends their current value.
Sent when the RtcManager is initialized and whenever the mode changes.
rtcstats reads the userRole event's value from its role property, both for the stored session info and for insights. It was sent as userRole, so the role was never recorded.
misi-whereby
force-pushed
the
misi/cob-3427-rtcstats-receives-the-user-role-under-the
branch
from
November 17, 2026 10:39
38ad47e to
fc97977
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
There is typo in customEvent:userRole
Related Issue:
Testing
Check customEvent:userRole value has "role" not "userRole" field.
Screenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Additional Information