Repository navigation
core: rtcstats sends a room's teardown events with the next room's session - #1193
Open
misi-whereby wants to merge 3 commits into
Open
misi-whereby wants to merge 3 commits into
misi-whereby wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 4904291 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
misi-whereby
marked this pull request as ready for review
November 11, 2026 09:19
misi-whereby
force-pushed
the
misi/cob-3439-rtcstats-loses-the-room-teardown-events-and
branch
3 times, most recently
from
November 11, 2026 15:27
ab00f63 to
27ea864
Compare
misi-whereby
force-pushed
the
misi/cob-3439-rtcstats-loses-the-room-teardown-events-and
branch
4 times, most recently
from
November 13, 2026 10:01
1efd0ec to
e151256
Compare
rtcstats connects with the page's path, and the server uses it as the room name. The server also uses the Origin header for the subdomain, and both in the stored file name. On a page that isn't the room's page, these are the page's, and a page can't set the Origin header. setRoomUrl() takes the room's origin and path: the connection then uses an empty path, so the page's path isn't sent, and the room's origin and path are sent in the roomUrl query parameter, for a server that reads it. It's used from the next connection. Without it, the URL is the same as before. After requireRoomUrl(), rtcstats doesn't connect while the room's URL isn't set, so the page's origin and path are never sent.
rtcstats uses the page's path as the room name, and the page's origin for the subdomain, and both in the stored file name. Core doesn't run on the room's page, so it gives rtcstats the room's origin and path when the app starts, and clears them when the app stops. The room URL's query isn't passed on, as it can hold a room key.
rtcstats was closed on doAppStop, before doDisconnectRtc tore down the peer connections. The teardown's events were then buffered and sent with the next room's rtcstats session. doDisconnectRtc now closes rtcstats after disconnectAll(), so these events are sent to the room they belong to.
misi-whereby
force-pushed
the
misi/cob-3439-rtcstats-loses-the-room-teardown-events-and
branch
from
November 17, 2026 10:39
e151256 to
4904291
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
rtcstats sends a room's teardown events with the next room's session
Related Issue:
Testing
Join a group (SFU) room, wait ~15 s, click "Leave room", then "Re-join"
It will create 2 rtcstats session.
After the fix expected: ["close","PC_2"…] and ["close","PC_3"…] in the rtcstats first session not in the second.
Screenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Additional Information